Bump Omicron and add new IP Pool column to networking table #2855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
approved these changes
Jul 15, 2025
|
I was concerned about adding noise to the diff in #2850 while we're still reviewing that one, but it's actually very small so I'm going to merge this. |
david-crespo
merged commit 5be3ca7
into
firewall_rules_set_and_view_filters
7 checks passed
david-crespo
added a commit
that referenced
this pull request
Jul 18, 2025
* Update pinned Omicron version * Update mock data; update filters list to show type / code in badge list * Updating form to handle ICMP types; UI not there yet; also needs ICMP codes sub-option * oops; license * Updates to handle proper protocol objects in the form * prevent duplicate protocols; convert mini table to columns showing protocol, type, code * add ProtocolBadge component * refactor; update tests * Refactoring and usability improvements * small tweaks * ProtocolCell and friends * Move away from badges in mini table for type and code * update Protocol Badge layout * a few more ProtocolBadge adjustments * Update test to account for new badge * Properly handle selective code combobox display * slight refactoring * refactoring * add icmp filter to the mock rule with lots of filters * try "parse, don't validate" on ICMP type * combobox values can't be numbers * tweak help copy * Bump Omicron and add new IP Pool column to networking table (#2855) * Bump Omicron further and add IP Pool ID column to networking tab * simplify IP Pool finding with safer fallback * Bump Omicron to latest and run gen-api; no changes to console * give IpPoolCell loading state, don't blow up on errors * A few post-review adjustments * Simpler handling of resolveIpPool * small type refactor * shorter getIpFromPool --------- Co-authored-by: David Crespo <[email protected]> * bind icmp type input value to form value --------- Co-authored-by: David Crespo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not tied to #2850, but as I worked on that PR, I wanted to be sure to pull in the "verify range values" changes from oxidecomputer/omicron#8578 (which, in hindsight, likely didn't actually affect anything in console).
When I bumped Omicron to pick Kyle's change up, I also picked up the changes in oxidecomputer/omicron#8564, which required some updates in console to resolve. To make sure that things were working right, I took care of #2852.
This will close #2852 when merged to main, though this PR is currently set to merge it back to the branch in #2850 to minimize the diff in the PR.
Closes #2852